Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
=======================================
Coverage 87.48% 87.48%
=======================================
Files 20 20
Lines 1262 1262
Branches 204 204
=======================================
Hits 1104 1104
Misses 74 74
Partials 84 84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bednar
requested changes
Nov 12, 2025
Member
bednar
left a comment
bednar
left a comment
There was a problem hiding this comment.
Thanks for your PR, please update examples/README.md with description about new example.
|
|
||
| <groupId>com.influxdb.v3.spring</groupId> | ||
| <artifactId>spring-example</artifactId> | ||
| <version>1.0-SNAPSHOT</version> |
Member
There was a problem hiding this comment.
Please add same version as is in the client
bednar
requested changes
Nov 12, 2025
|
|
||
| private Application() { } | ||
|
|
||
| static Logger logger = LoggerFactory.getLogger(Application.class); |
Member
There was a problem hiding this comment.
Use Lombok annotation for loggers:
Member
|
Not finished. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds a basic example of integrating the client with a Spring based project.
Checklist